signal.c: Change printsignal to properly handle xlat styles

shankarapailoor shankarapailoor at gmail.com
Sat Dec 22 20:48:50 UTC 2018


>No, apparently it wouldn't.
>
>I've finally managed to disentangle the relevant commits from Eugene's
>next-ng2 branch, so I'm going to merge them now into master
>along with your test.

Thanks. Sorry, I was just about to send a patch.

On Sat, Dec 22, 2018 at 12:28 PM Dmitry V. Levin <ldv at altlinux.org> wrote:
>
> On Sat, Dec 22, 2018 at 08:49:10PM +0300, Dmitry V. Levin wrote:
> > On Fri, Dec 21, 2018 at 08:05:53PM -0800, shankarapailoor wrote:
> > > >btw, have you tried to invoke k_sigaction with an invalid signal number,
> > > e.g. -1?  Does the output look good in verbose mode?
> > >
> > > Ah good point. I didn't consider that. With my change verbose mode
> > > prints -1 /* -1 */ which is wrong. Here is a patch which addresses
> > > that along with your above comments.
> >
> > Would the output still be OK in verbose mode in case of other
> > invalid signal numbers, e.g. 256?
>
> No, apparently it wouldn't.
>
> I've finally managed to disentangle the relevant commits from Eugene's
> next-ng2 branch, so I'm going to merge them now into master
> along with your test.
>
> Everything seems to work as expected now, thanks!
>
>
> --
> ldv
> --
> Strace-devel mailing list
> Strace-devel at lists.strace.io
> https://lists.strace.io/mailman/listinfo/strace-devel



-- 
Regards,
Shankara Pailoor


More information about the Strace-devel mailing list