signal.c: Change printsignal to properly handle xlat styles

Dmitry V. Levin ldv at altlinux.org
Sat Dec 22 20:28:05 UTC 2018


On Sat, Dec 22, 2018 at 08:49:10PM +0300, Dmitry V. Levin wrote:
> On Fri, Dec 21, 2018 at 08:05:53PM -0800, shankarapailoor wrote:
> > >btw, have you tried to invoke k_sigaction with an invalid signal number,
> > e.g. -1?  Does the output look good in verbose mode?
> > 
> > Ah good point. I didn't consider that. With my change verbose mode
> > prints -1 /* -1 */ which is wrong. Here is a patch which addresses
> > that along with your above comments.
> 
> Would the output still be OK in verbose mode in case of other
> invalid signal numbers, e.g. 256?

No, apparently it wouldn't.

I've finally managed to disentangle the relevant commits from Eugene's
next-ng2 branch, so I'm going to merge them now into master
along with your test.

Everything seems to work as expected now, thanks!


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20181222/5a73be08/attachment.bin>


More information about the Strace-devel mailing list