[PATCH] strace.spec: Add %check section with basic "strace -f" tests

Dmitry V. Levin ldv at altlinux.org
Sun Feb 27 15:06:45 UTC 2011


On Tue, Feb 22, 2011 at 06:54:38PM -0800, Roland McGrath wrote:
> That looks fine to me.  For the future, I'd be inclined to have any such
> things in 'make check' instead, or perhaps 'make xcheck', and
> conditionalize them on the configured $host_os or perhaps on uname -sr
> results matching "Linux 2.6.*" or something.  There's no reason for
> anything that's just specific to modern Linux to be isolated to only the
> rpm .spec file, where it will only apply to Fedora builds and not Debian
> and any other packaging that others may do.

Agreed.  I've implemented that via "make check":
http://strace.git.sourceforge.net/git/gitweb.cgi?p=strace/strace;a=commitdiff;h=v4.5.20-93-g4e4b5ad
http://strace.git.sourceforge.net/git/gitweb.cgi?p=strace/strace;a=commitdiff;h=v4.5.20-94-g983e875


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20110227/afa156de/attachment.bin>


More information about the Strace-devel mailing list