[PATCH] strace.spec: Add %check section with basic "strace -f" tests

Roland McGrath roland at redhat.com
Wed Feb 23 02:54:38 UTC 2011


That looks fine to me.  For the future, I'd be inclined to have any such
things in 'make check' instead, or perhaps 'make xcheck', and
conditionalize them on the configured $host_os or perhaps on uname -sr
results matching "Linux 2.6.*" or something.  There's no reason for
anything that's just specific to modern Linux to be isolated to only the
rpm .spec file, where it will only apply to Fedora builds and not Debian
and any other packaging that others may do.


Thanks,
Roland




More information about the Strace-devel mailing list