[PATCH] Slight optimization and cleanup in trace()

Denys Vlasenko dvlasenk at redhat.com
Mon Aug 15 10:30:41 UTC 2011


On Tue, 2011-08-02 at 01:25 +0400, Dmitry V. Levin wrote:
> On Sat, Jun 25, 2011 at 11:34:01AM +0200, Denys Vlasenko wrote:
> > Slight optimization and cleanup in trace():
> > 
> > - do not recalculate "cflag ? &ru : NULL" again and again
> > - do not clear errno unnecessarily
> > - consistently check wait errors as pid < 0, not pid == -1
> > - indent ifdefs for better readability
> > - remove comments after endif if ifdef/endif block is really tiny
> > 
> > Does it look ok to you?
> 
> OK for me.

Applied, thanks!

-- 
vda






More information about the Strace-devel mailing list