[PATCH] Slight optimization and cleanup in trace()

Dmitry V. Levin ldv at altlinux.org
Mon Aug 1 21:25:52 UTC 2011


On Sat, Jun 25, 2011 at 11:34:01AM +0200, Denys Vlasenko wrote:
> Slight optimization and cleanup in trace():
> 
> - do not recalculate "cflag ? &ru : NULL" again and again
> - do not clear errno unnecessarily
> - consistently check wait errors as pid < 0, not pid == -1
> - indent ifdefs for better readability
> - remove comments after endif if ifdef/endif block is really tiny
> 
> Does it look ok to you?

OK for me.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20110802/0927b592/attachment.bin>


More information about the Strace-devel mailing list