[PATCH] enable LFS support by default

[Mike Frysinger]

On Tuesday 24 March 2009 20:23:36 Dmitry V. Levin wrote:
> On Thu, Mar 05, 2009 at 10:02:53PM -0500, Mike Frysinger wrote:
> >  configure.ac |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index ffbfeb4..e0b341a 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -173,6 +173,7 @@ AC_PROG_CPP
> >  AC_PROG_GCC_TRADITIONAL
> >  AC_PROG_INSTALL
> >  AC_C_CONST
> > +AC_SYS_LARGEFILE
> >  AC_HEADER_STDC
> >  AC_HEADER_STDBOOL
> >  AC_HEADER_DIRENT
>
> No, this oneliner doesn't work for strace, it just breaks build on x86:
>
> file.c: In function 'printoldstat':
> file.c:1249: warning: implicit declaration of function 'realprintstat'
> io.c: In function 'sys_sendfile':
> io.c:323: warning: format '%lu' expects type 'long unsigned int', but
> argument 2 has type 'off_t' io.c: At top level:
> io.c:352: error: redefinition of 'sys_pread'
> io.c:281: error: previous definition of 'sys_pread' was here
> io.c:374: error: redefinition of 'sys_pwrite'
> io.c:299: error: previous definition of 'sys_pwrite' was here
> make[1]: *** [io.o] Error 1

if that breaks x86, that means the code is already broken.  you simply arent 
seeing it in the default build.
CPPFLAGS='-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE'
export CPPFLAGS
./configure
make
<build failure>
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20090324/bcf8ec08/attachment.bin>