[PATCH v1 0/6] netlink netfilter decoder

[Dmitry V. Levin]

Hi,

On Thu, Jun 12, 2025 at 11:56:00AM +0200, Mathis Marion wrote:
> From: Mathis Marion <mathis.marion at silabs.com>
> 
> Hello,
> 
> I have been using strace to analyze the nftables kernel API, and ended
> up implementing some decoders. This is by no means complete, but I
> included already quite a lot of attributes. I hope that the community
> will find this valuable.

Thank you for contributing these decoders.  I assume you've been using
some tools to generate so many decoding tables, could you share them
as well?

> I manually tested this series using 'strace nft', but I am opened to
> spend a bit of time on writing unit tests if necessary. Testing all
> attributes seems unreasonable though so I am interested to know more
> about the project's expectations.

We usually strive to have test coverage for every new function being
added.  When a new table is added, there is no need to test every constant
in that table (although in some decoders we test every constant), but at
least one constant from the table should be tested to test the use of the
table.


-- 
ldv