[RFC PATCH v3 4/5] Add test for --decode-fds=eventfd

Sahil icegambit91 at gmail.com
Mon May 13 18:05:54 UTC 2024


Hi,

On Monday, May 13, 2024 5:41:51 PM GMT+5:30 Dmitry V. Levin wrote:
> On Fri, May 10, 2024 at 10:44:10AM +0530, Sahil Siddiq wrote:
> [...]
> > +        matches += 1;
> 
> ++matches or matches++ would look more natural.
> 
> > +        if (!strncmp(search_pfx, "eventfd-id:", search_pfx_len)) {
> 
> Wouldn't it be better to conditionalize on fdinfo_lines[i].data instead?
>

Yes. Now that I think about it, it will be better to use "fdinfo_lines[i].data"
here.

Thanks,
Sahil





More information about the Strace-devel mailing list