[PATCH v2] xlat: Mark IPPROTO_MAX last in IPPROTO_* constants

[Khem Raj]

On Thu, Oct 8, 2020 at 7:07 AM Eugene Syromiatnikov <esyr at redhat.com> wrote:
>
> On Wed, Oct 07, 2020 at 01:17:16PM -0700, Khem Raj wrote:
> > * xlat/inet_protocols.in (IPPROTO_MAX): It should be the last entry
> >   after adding IPPROTO_MPTCP this should have new value as
> >   IPPROTO_MPTCP + 1.
>
> Well, this is bad.  This is either an UAPI breakage, or (more likely),
> it is considered non-UAPI (even if it isn't explicitly marked so in
> the UAPI header) and should be removed from xlat altogether, then.

right looking at glibc headers latter seems to be the case.

>
> > ---
> > v2: Fix typo 253 -> 263
> >
> >  xlat/inet_protocols.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xlat/inet_protocols.in b/xlat/inet_protocols.in
> > index c37508fa..cc60e7f9 100644
> > --- a/xlat/inet_protocols.in
> > +++ b/xlat/inet_protocols.in
> > @@ -32,5 +32,5 @@ IPPROTO_UDPLITE             136
> >  IPPROTO_MPLS         137
> >  IPPROTO_ETHERNET     143
> >  IPPROTO_RAW          255
> > -IPPROTO_MAX          256
> >  IPPROTO_MPTCP                262
> > +IPPROTO_MAX          263
> > --
> > 2.28.0
> >
> > --
> > Strace-devel mailing list
> > Strace-devel at lists.strace.io
> > https://lists.strace.io/mailman/listinfo/strace-devel
> >
>