[PATCH v2 2/2] ioctl console test v2

Bran S archsbran at gmail.com
Thu Mar 12 12:32:17 UTC 2020


> > > Have you considered fixing strace-DDD.test?
> >
> > It is mentioned here[1] that it doesn't fail when built outside
> > systemd user slice.
>
> There are actually two issues: one is itermittent and is common with
> strace-DD.test, namingly, the waiting of the strace's termination is not
> done properly, so it checks the actual strace's output too early
> sometimes; the other one is the one you've referenced, yes.
>
> > So should we check if the ppid is of the systemd instead of checking for pid 1 ?
> > Would that be a solution or something else ?
>
> Why systemd?  Any process can be child subreaper for whatever reasons.
> Yes, it's likely that the solution is to get the subreaper's PID and
> check against it instead of checking against hard-coded 1.

So if any process can be subreaper i.e. ppid can be anything greater
than equal to 1, then what is the point of matching the process id ?
Wouldn't it be enough to just confirm that a process whose pid is
equal to ppid exists ?

> > [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947396


More information about the Strace-devel mailing list