[PATCH v2 2/2] ioctl console test v2

Eugene Syromiatnikov esyr at redhat.com
Wed Mar 11 13:44:54 UTC 2020

On Wed, Mar 11, 2020 at 03:01:38PM +0530, Bran S wrote:
> > Have you considered fixing strace-DDD.test?
> It is mentioned here[1] that it doesn't fail when built outside
> systemd user slice.

There are actually two issues: one is itermittent and is common with
strace-DD.test, namingly, the waiting of the strace's termination is not
done properly, so it checks the actual strace's output too early
sometimes; the other one is the one you've referenced, yes.

> So should we check if the ppid is of the systemd instead of checking for pid 1 ?
> Would that be a solution or something else ?

Why systemd?  Any process can be child subreaper for whatever reasons.
Yes, it's likely that the solution is to get the subreaper's PID and
check against it instead of checking against hard-coded 1.

> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947396

More information about the Strace-devel mailing list