[PATCH 7/9] unwind: add libdw as a unwinder

Mark Wielaard mjw at redhat.com
Sun Mar 18 00:50:47 UTC 2018


On Sun, Mar 18, 2018 at 03:32:02AM +0900, Masatake YAMATO wrote:
> I'm thinking about putting following notice at the head
> of my v2 patch. How, do you think?
> 
> ========================================================
> /*
> * This file is mostly based on git commit
> * dfefa9f057857735a073ea655f5cb34351032c8e
> * of ltrace submitted by Mark Wielaard <mjw at redhat.com>.
> * https://anonscm.debian.org/cgit/collab-maint/ltrace.git/commit/?id=dfefa9f057857735a07
> a655f5cb34351032c8e
> *
> * It is re-licensed by the original author to make adapting this code
> * to strace simple.
> *
> * NOTE: The unwinder, elfutils libdw itself is distributed under the GPL/LGPL.
> */

I think this part isn't really necessary. It was just a small snippet
of code which you adapted to work with strace.

> /*
>  * Copyright (c) 2018 Mark Wielaard
>  * Copyright (c) 2018 The strace developers.

I don't know how the strace project handles their copyright notices.
But if you add my name, then please add your own too. You did most of
the work.

>  * Redistribution and use in source and binary forms, with or without
>  * modification, are permitted provided that the following conditions
>  * are met:
>  * 1. Redistributions of source code must retain the above copyright
>  *    notice, this list of conditions and the following disclaimer.
>  * 2. Redistributions in binary form must reproduce the above copyright
>  *    notice, this list of conditions and the following disclaimer in the
>  *    documentation and/or other materials provided with the distribution.
>  * 3. The name of the author may not be used to endorse or promote products
>  *    derived from this software without specific prior written permission.
>  *
>  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
>  * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
>  * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
>  * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
>  * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
>  * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
>  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
>  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
>  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>  */
> ========================================================

I am fine with the license notice itself.

Thanks,

Mark


More information about the Strace-devel mailing list