[PATCH v4] Fix missing flags in stat related compatibility syscalls

Abhishek Tiwari erabhishektiwarics at gmail.com
Wed Mar 29 07:53:58 UTC 2017


On Wed, Mar 29, 2017 at 4:47 AM, Dmitry V. Levin <ldv at altlinux.org> wrote:
> On Tue, Mar 28, 2017 at 09:26:20AM +0530, Abhishek Tiwari wrote:
>> From f6d4386bd952ee6ac1983937cc631ececf5bc277 Mon Sep 17 00:00:00 2001
>> From: Abhishek Tiwari <erabhishektiwarics at gmail.com>
>> Date: Tue, 28 Mar 2017 09:20:07 +0530
>> Subject: [PATCH v4] Fix missing flags in stat related compatibility syscalls
>
> As this affects alpha and mips only, it's a good habit to add a prefix,
> e.g. "alpha, mips:".
>
>> Following commands do the fix:
>>
>> Add TF flag, fixed by:
>>       git grep -Fl '_stat' linux/*/syscallent* | xargs sed -i \
>>               's/0\(,[[:space:]]*SEN(.*_l\?stat[^i]\)/TF\1/'
>>
>> Add TD flag, fixed by:
>>       git grep -Fl '_stat' linux/*/syscallent* | xargs sed -i \
>>         's/0\(,[[:space:]]*SEN(.*_fstat\)/TD\1/'
>>
>> * linux/alpha/syscallent.h: Add TF and TD flags for stat related compat syscalls .
>
> This line is longer than 72 symbols.
>
>> * linux/mips/syscallent-compat.h: Likewise.
>
> OK, overall good enough.  I'm still not quite comfortable with the mips
> part because the whole mips/syscallent-compat.h is just a neglected piece
> of crap, but that shouldn't bother you.
>
> I think I'll apply this now, thanks.
>
>
> --
> ldv
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Strace-devel mailing list
> Strace-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/strace-devel
>

Thank you :)

I have edited commit message as per your suggestions above. Consider
below patch if needed.


-- 
Abhishek Tiwari
M.Tech (CS),
IIT Kharagpur.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v5-0001-alpha-mips-Fix-missing-flags-in-stat-related-comp.patch
Type: text/x-patch
Size: 12324 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170329/5b1e8eb8/attachment.bin>


More information about the Strace-devel mailing list