[PATCH v1] Fixed bug by adding TF flag to statfs and statvfs like syscalls

Dmitry V. Levin ldv at altlinux.org
Fri Mar 24 02:04:04 UTC 2017


On Sun, Mar 19, 2017 at 10:40:02AM +0530, Abhishek Tiwari wrote:
> From c12a70031d8c3d390712c3cf3c811bc775b4eb37 Mon Sep 17 00:00:00 2001
> From: Abhishek Tiwari <erabhishektiwarics at gmail.com>
> Date: Sun, 19 Mar 2017 10:18:48 +0530
> Subject: [PATCH v1] Fixed bug by adding TF flag to statfs and statvfs

Commit messages must be written in the present tense.
The first line of commit message must be concise and to the point.

For example, use "Fix" instead of "Fixed".
Never say "Fixed bug" - it's a waste of time and space.
Instead, say what's being fixed.

> Following command fixed the bug:
> 
> 	git grep -Fl 'statfs' linux/*/syscallent* | xargs sed -i \
> 		's/0\(,[[:space:]]*SEN(.*_stat\(\|v\)fs\)/TF\1/'

You can use v\? instead of \(\|v\).

> * linux/alpha/syscallent.h: Added TF flag to statfs and statvfs syscalls

Really statfs and statvfs?  I thought it was something different from
compat world.

> * linux/mips/syscallent-compat.h: Likewise.

Likewise.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170324/8ebf15fd/attachment.bin>


More information about the Strace-devel mailing list