[PATCH v3 2/6] Introduce new filtering architecture

Dmitry V. Levin ldv at altlinux.org
Tue Jul 4 20:42:44 UTC 2017


On Thu, Jun 29, 2017 at 02:46:11PM +0700, Nikolay Marchuk wrote:
[...]
> --- a/defs.h
> +++ b/defs.h
> @@ -228,7 +228,7 @@ struct tcb {
>  	void (*_free_priv_data)(void *); /* Callback for freeing priv_data */
>  	const struct_sysent *s_ent; /* sysent[scno] or dummy struct for bad scno */
>  	const struct_sysent *s_prev_ent; /* for "resuming interrupted SYSCALL" msg */
> -	struct inject_opts *inject_vec[SUPPORTED_PERSONALITIES];
> +	struct inject_opts *inject_opts;

Looks like this and related changes break the following
important property of injections:

$ grep -A1 Accounting strace.1
Accounting of syscalls that are subject to injection
is done per syscall and per tracee.

qual_fault.test has been extended to check this property,
please ensure that your changes don't break it.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170704/c489b5bf/attachment.bin>


More information about the Strace-devel mailing list