[PATCH v7 07/18] tests: check decoding of inet_diag_msg attributes

JingPiao Chen chenjingpiao at gmail.com
Sat Jul 1 15:26:15 UTC 2017


On Sat, Jul 01, 2017 at 01:21:29PM +0300, Dmitry V. Levin wrote:
> On Wed, Jun 28, 2017 at 09:40:02AM +0800, JingPiao Chen wrote:
> > * tests/nlattr_inet_diag_msg.c: New file.
> 
> Well, this is big and full of redundancy.
> The longer I looked at this approach, the more unbearable was the feeling
> of redundancy in tons of cut-n-paste in this and subsequently added nlattr
> tests that cannot be reviewed properly.

Thank you. I also think it is too big, I have try to find a solution,
but not satisfied.

> 
> So I tried a different approach, see v4.17-138-gaecff11 applied on top
> of yours.  It worked well so I applied similar changes on top of
> a few more of your new nlattr tests (up to 12/18 of these series).
> 
> Please follow that approach when adding new nlattr tests.

Ok.

--
JingPiao Chen




More information about the Strace-devel mailing list