[PATCH v7 07/18] tests: check decoding of inet_diag_msg attributes

Dmitry V. Levin ldv at altlinux.org
Sat Jul 1 10:21:29 UTC 2017


On Wed, Jun 28, 2017 at 09:40:02AM +0800, JingPiao Chen wrote:
> * tests/nlattr_inet_diag_msg.c: New file.

Well, this is big and full of redundancy.
The longer I looked at this approach, the more unbearable was the feeling
of redundancy in tons of cut-n-paste in this and subsequently added nlattr
tests that cannot be reviewed properly.

So I tried a different approach, see v4.17-138-gaecff11 applied on top
of yours.  It worked well so I applied similar changes on top of
a few more of your new nlattr tests (up to 12/18 of these series).

Please follow that approach when adding new nlattr tests.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170701/68dfc465/attachment.bin>


More information about the Strace-devel mailing list