[PATCH] Re: cross-compiling strace on non-Linux build

Dmitry V. Levin ldv at altlinux.org
Fri Jan 13 03:32:44 UTC 2017

On Thu, Jan 12, 2017 at 07:13:08PM -0800, Alexey Neyman wrote:
> Updated patch attached.
> On 01/12/2017 05:58 PM, Dmitry V. Levin wrote:
> >1st, I slightly prefer ioctl_iocdef over ioctls_iocdef.
> >2nd, we usually keep intermediate targets.
> >3rd, the right way to invoke the preprocessor is $(CPP) with all its 
> >options.
> >4th, sed after grep is a bad shell style.
> >5th, let's make "ioctl_iocdef.h" a 100% replacement of <linux/ioctl.h> for 
> >ioctlsort.c.
> Re #5, I thought about it but decided that a clear indication of using 
> host values would be better. Since you prefer the other way, changed to 
> remove HOST prefix.

I've added ioctl_iocdef.i to CLEANFILES, added a gnu style changelog entry
to the commit message, and merged it.  Thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170113/d15bd729/attachment.bin>

More information about the Strace-devel mailing list