[PATCH] Re: cross-compiling strace on non-Linux build

Alexey Neyman stilor at att.net
Fri Jan 13 03:13:08 UTC 2017


Updated patch attached.

On 01/12/2017 05:58 PM, Dmitry V. Levin wrote:
> 1st, I slightly prefer ioctl_iocdef over ioctls_iocdef.
> 2nd, we usually keep intermediate targets.
> 3rd, the right way to invoke the preprocessor is $(CPP) with all its options.
> 4th, sed after grep is a bad shell style.
> 5th, let's make "ioctl_iocdef.h" a 100% replacement of <linux/ioctl.h> for ioctlsort.c.
Re #5, I thought about it but decided that a clear indication of using 
host values would be better. Since you prefer the other way, changed to 
remove HOST prefix.
>> + * Copyright (c) 2001 Wichert Akkerman <wichert at cistron.nl>
>> + * Copyright (c) 2004-2015 Dmitry V. Levin <ldv at altlinux.org>
>> + * All rights reserved.
> I'm sorry but this is not true, I didn't write this.
I thought the copyrights covered the whole product. Changed to my own name.

Regards,
Alexey.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ioctlsort-Get-ioctl-definitions-from-host-not-build.patch
Type: text/x-patch
Size: 4894 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170112/a7bc61ec/attachment.bin>


More information about the Strace-devel mailing list