[PATCH 00/21] Some possible additions to the DM ioctl patch for strace

Eugene Syromyatnikov evgsyr at gmail.com
Sun Oct 9 13:27:52 UTC 2016


I've took the liberty to look at the patch and I'd like to propose some
changes to it. Can you please review them from the DM side of things?
I'm not quite sure I've understood all the specifics of the interface correctly,
it's quite peculiar.

I'm also preparing a patch for the DM ioctl decoder test, but it's not ready

Eugene Syromyatnikov (21):
  tests/ioctl_dm: Formatting
  dm: whitespace fixes
  tests: Working around bounds check
  dm: Minor output tweaks
  xlat: Add values for dm_flags
  dm: Some future-proofing by means of compile-time DM_VERSION_MAJOR
  dm: Add definitions for ioctl commands not implemented initially
  dm: Use static constants for offset sizes
  dm: Remove char * cast
  dm: use => instead of , for splitting output structure from input
  dm: Compare entering field values with exiting ones
  dm: Add inttypes.h, include reorder
  dm: Move printing of dm_ioctl fields before allocation of extra data
  dm: replace abbrev branching with goto
  dm: Additional data_size/data_start checks
  dm: Add comment regarding intended fall-through in switch statement
  dm: Add data_size and data_offset fields to output
  tests/ioctl_dm: Allow passing size and data_start to init_s
  dm: Add check whether command uses parameters
  dm: Fix printing of version field
  dm: rewrite structure decoding

 dm.c             |  549 ++++++++++++++++++++++++++++++++++++------------------
 tests/ioctl_dm.c |   79 +++++---
 xlat/dm_flags.in |   36 ++--
 3 files changed, 442 insertions(+), 222 deletions(-)


More information about the Strace-devel mailing list