[PATCH] Re: your dm patch for strace

Masatake YAMATO yamato at redhat.com
Wed Oct 5 10:28:28 UTC 2016


I tested the patch and it works fine.
Could you add following patch if you approve?

commit bae7528fa92283726caac1ec7a6c306274f8899d
Author: Masatake YAMATO <yamato at redhat.com>
Date:   Mon Aug 22 17:44:55 2016 +0900

    dm-ioctl: add a lvm private flag
    
    When I run "dmsetup ls" under dm-ioctl patched strace,
    "strange DM_???" are found in its output.
    
        # ./strace -e ioctl dmsetup ls > /dev/null
        ioctl(3, DM_VERSION, {version=4.0.0, flags=0x4 /* DM_??? */}, ...
        ioctl(3, DM_LIST_DEVICES, {version=4.0.0, flags=0x4 /* DM_??? */}, ...
        ...
    
    Associated definion for DM_??? is in lvm2 source tree. This commit
    imports the definion to dm-ioctl list.
    
    Signed-off-by: Masatake YAMATO <yamato at redhat.com>

diff --git a/xlat/dm_flags.in b/xlat/dm_flags.in
index ab4285c..1e7132b 100644
--- a/xlat/dm_flags.in
+++ b/xlat/dm_flags.in
@@ -1,5 +1,7 @@
 DM_READONLY_FLAG
 DM_SUSPEND_FLAG
+/* Defined in lvm2/libdm/ioctl/libdm-iface.c */
+DM_EXISTS_FLAG 0x00000004
 DM_PERSISTENT_DEV_FLAG
 DM_STATUS_TABLE_FLAG
 DM_ACTIVE_PRESENT_FLAG




More information about the Strace-devel mailing list