[PATCH v3 1/7] Make getfdproto returns integer instead of string

[Dmitry V. Levin]

On Thu, Jun 16, 2016 at 12:25:02PM +0000, Fabien Siron wrote:
> Quoting Dmitry V. Levin (2016-06-15 17:36:35)
> > On Wed, Jun 15, 2016 at 12:42:59PM +0000, Fabien Siron wrote:
> > > This commit aims to avoid future string comparisons with getfdproto function
> > > in changing its return type. It also adapts the functions that use it.
> > 
> > I'm not quite sure what does the first sentence mean.
> 
> Do you prefer "This commit introduces a new type (sock_proto) which replaces 
> strings for socket protocols."?

I'd like something like "Introduce a new enum type sock_proto and use it
instead of strings for socket protocols identification.".

> > > * defs.h (print_sockaddr_by_inode, get_proto_by_name): Add.
> > 
> > Only get_proto_by_name is a new prototype, print_sockaddr_by_inode was
> > there before the change.
> > 
> > > (sock_proto): New enum.
> > > * socketutils.c (print_sockaddr_by_inode): Move proto to int.
> > 
> > I'm not quite sure what does "Move proto to int" mean.
> 
> Do you prefer "Convert proto argument to sock_proto type."?

I'd rather write "Change type of "proto" argument to sock_proto.".


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160616/29bb66be/attachment.bin>