[PATCH v3 1/7] Make getfdproto returns integer instead of string
fabien.siron at epita.fr
Thu Jun 16 12:25:02 UTC 2016
Quoting Dmitry V. Levin (2016-06-15 17:36:35)
> On Wed, Jun 15, 2016 at 12:42:59PM +0000, Fabien Siron wrote:
> > This commit aims to avoid future string comparisons with getfdproto function
> > in changing its return type. It also adapts the functions that use it.
> I'm not quite sure what does the first sentence mean.
Do you prefer "This commit introduces a new type (sock_proto) which replaces
strings for socket protocols."?
> > * defs.h (print_sockaddr_by_inode, get_proto_by_name): Add.
> Only get_proto_by_name is a new prototype, print_sockaddr_by_inode was
> there before the change.
> > (sock_proto): New enum.
> > * socketutils.c (print_sockaddr_by_inode): Move proto to int.
> I'm not quite sure what does "Move proto to int" mean.
Do you prefer "Convert proto argument to sock_proto type."?
More information about the Strace-devel