[SCM] strace branch, master, updated. v4.10-25-g8497b62

[Dmitry V. Levin]

Hi,

On Sat, Mar 21, 2015 at 05:06:32PM +0000, Denys Vlasenko wrote:
[...]
> commit 8497b6222ed8ef606996d0ceb2bae260d82f95e2
> Author: Denys Vlasenko <dvlasenk at redhat.com>
> Date:   Sat Mar 21 17:51:52 2015 +0100
> 
>     Show the syscall name in "resuming interrupted call" message

It's nice when it works, but you've broken ARM and probably other
architectures:

$ ./strace true
pid 1234 stray syscall exit
Segmentation fault

[...]
> --- a/strace.c
> +++ b/strace.c
> @@ -2153,6 +2153,8 @@ trace(void)
>  	if (tcp->flags & TCB_STARTUP) {
>  		if (!startup_tcb(tcp))
>  			return false;
> +		if (get_scno(tcp) == 1)
> +			tcp->s_prev_ent = tcp->s_ent;

Here you call get_scno() which was never called outside
trace_syscall_entering() before.  Every architecture implements get_scno()
in its own way, and some of these implementations are not ready for this
change.

Denys, please post non-trivial patches for review before pushing them
to HEAD.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20150323/6b9850c1/attachment.bin>