trouble in kernel header inclusion in ./ioctls_gen.sh

[Mike Frysinger]

On 04 Mar 2015 02:21, Dmitry V. Levin wrote:
> On Tue, Mar 03, 2015 at 06:09:28PM -0500, Mike Frysinger wrote:
> > On 04 Mar 2015 06:40, Masatake YAMATO wrote:
> > > When I run ioctls_gen.sh by hand, I got some errors:
> > > 
> > >     $ ./ioctls_gen.sh ~/var/linux/include ~/var/linux/arch/x86/include
> > >     ...
> > >     /home/yamato/var/linux/include/uapi/linux/am437x-vpfe.h:122:12: error: ‘BASE_VIDIOC_PRIVATE’ undeclared (first use in this function)
> > >       _IOW('V', BASE_VIDIOC_PRIVATE + 1, void *)
> > > 		^
> > >     /tmp/ioctls_sym.sh.DPfTZI/asm/ioctl.h:3:43: note: in definition of macro ‘_IOC’
> > >      #define _IOC(dir,type,nr,size) dir, type, nr, size
> > >     ...
> > > 
> > > BASE_VIDIOC_PRIVATE is defined in linux/videodev2.h.
> > > 
> > > With a following patch, ioctls_gen.sh works well without above error.
> > > 
> > >     diff --git a/include/uapi/linux/am437x-vpfe.h b/include/uapi/linux/am437x-vpfe.h
> > >     index 9b03033f..c28b4e4 100644
> > >     --- a/include/uapi/linux/am437x-vpfe.h
> > >     +++ b/include/uapi/linux/am437x-vpfe.h
> > >     @@ -20,6 +20,7 @@
> > > 
> > >      #ifndef AM437X_VPFE_USER_H
> > >      #define AM437X_VPFE_USER_H
> > >     +#include <linux/videodev2.h>
> > > 
> > >      enum vpfe_ccdc_data_size {
> > > 	    VPFE_CCDC_DATA_16BITS = 0,
> > > 
> > > Do you think I should report this to LKML?
> > 
> > the v4l list, but otherwise yes.  you should be able to include any of these 
> > headers by themselves w/out things failing.  periodically i send one or two 
> > updates when i get around to it where a header fails to include another one it 
> > needs.
> 
> Unfortunately, ioctls_sym.sh couldn't wait for all kernel headers got
> fixed, so I had to load ioctls_sym.sh with a lot of workarounds.

right ... i wasn't trying to say that all the workarounds in strace should be 
punted
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20150303/c1af2ac3/attachment.bin>