Preparing for the next release: call for testing
enh at google.com
Fri Dec 11 03:33:42 UTC 2015
d'oh. yeah, adding HAVE_LINUX_IPC_H fixes it.
On Thu, Dec 10, 2015 at 11:38 AM, Dmitry V. Levin <ldv at altlinux.org> wrote:
> On Thu, Dec 10, 2015 at 10:54:55AM -0800, Elliott Hughes wrote:
>> other than one small patch to build (below and attached, since gmail
>> mangles these things), lgtm on Android.
>> If we build strace against the untouched Linux kernel uapi headers (as used
>> by bionic), the key fields are called 'key', not '__key'.
>> * ipc_msgctl.c, ipc_shmctl.c: Add #define workaround.
> Both files already include "ipc_defs.h" which in turn defines __key
> to key in HAVE_LINUX_IPC_H case. Unless you define HAVE_LINUX_MSG_H
> and HAVE_LINUX_SHM_H without defining HAVE_LINUX_IPC_H (which is probably
> not the right thing to do), your patch will break build with linux uapi
> headers rather than fix it.
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.
More information about the Strace-devel