[PATCH 2/2] stack trace support: print full instruction pointer in addition to offset

[Dmitry V. Levin]

Hi,

On Fri, Nov 07, 2014 at 02:07:40PM +0900, Masatake YAMATO wrote:
> On Thu, 6 Nov 2014 21:07:52 +0100, Thomas De Schampheleire <patrickdepinguin at gmail.com> wrote:
> >> How do you think one of following format?
> >>
> >>  > /bin/busybox() [0x10062c60|0x62c60]
> >>  > /bin/busybox() [0x10062c60/0x62c60]
> >>  > /bin/busybox() [0x10062c60:0x62c60]
> > 
> > Yes, I'm fine with such reduced format. Of the three you suggested, I
> > find the second version with / most readable.
> 
> Next one is optional request.
> Could you transpose relative ip and absolute ip like:
> 
>    > /bin/busybox() [0x62c60/0x10062c60]
> 
> A string representation of absolute ip may be logger than tat of relative ip.
> I think it is better that shorter one is in front of longer one.
> 
> > Should I already rework with this change or wait for more feedback?
> 
> I have no more comment.
> Dmitry, I wonder how do you think.

The last suggestion [0x62c60/0x10062c60] is fine with me.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20141112/0fa10bf6/attachment.bin>