[PATCH 2/2] stack trace support: print full instruction pointer in addition to offset

Masatake YAMATO yamato at redhat.com
Fri Nov 7 05:07:40 UTC 2014


Hi,

On Thu, 6 Nov 2014 21:07:52 +0100, Thomas De Schampheleire <patrickdepinguin at gmail.com> wrote:
>> How do you think one of following format?
>>
>>  > /bin/busybox() [0x10062c60|0x62c60]
>>  > /bin/busybox() [0x10062c60/0x62c60]
>>  > /bin/busybox() [0x10062c60:0x62c60]
> 
> Yes, I'm fine with such reduced format. Of the three you suggested, I
> find the second version with / most readable.

Next one is optional request.
Could you transpose relative ip and absolute ip like:

   > /bin/busybox() [0x62c60/0x10062c60]

A string representation of absolute ip may be logger than tat of relative ip.
I think it is better that shorter one is in front of longer one.

> Should I already rework with this change or wait for more feedback?

I have no more comment.
Dmitry, I wonder how do you think.

Masatake YAMATO




More information about the Strace-devel mailing list