[PATCH] Add support for Altera's Nios-II softcore architecture

James Hogan james.hogan at imgtec.com
Tue Feb 4 21:39:30 UTC 2014


On 04/02/14 21:28, Ezequiel García wrote:
> James,
> 
> On 29 January 2014 10:03, James Hogan <james.hogan at imgtec.com> wrote:
> [..]
>>
>> Arnd also recommends new kernel ports to use regsets for ptrace
>> (PTRACE_{GET,SET}REGSET rather than PTRACE_{PEEK,POKE}USER) so that
>> arch_ptrace() is a simple wrapper around ptrace_request. See here for
>> example:
>> http://marc.info/?l=linux-arch&m=135272829410342&w=2
>>
> 
> Yes, I saw the REGSET stuff and took some deep look at openrisc and
> metag while trying to fix nios2 strace. It is definitely cleaner.
> 
>> So the offsets you've added to struct_user_offsets would need removing
>> too, and get_regs would need to use get_regset as is done for METAG etc.
>> Should simplify the code if anything though.
>>
> 
> Indeed. Which means we can always fix this later, and this patch _can_
> be merged in its current form (with the fixes suggested above).
> 
> How does it sounds? If you really want to wait until the arch is
> merged upstream, fine by me: I'll stop bothering.

It wouldn't bother me (I just wanted to clarify that some other changes
would eventually be required in addition to the syscall list), but it's
not my call either :)

Cheers
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20140204/ecc33ebe/attachment.bin>


More information about the Strace-devel mailing list