[PATCH] Add support for Altera's Nios-II softcore architecture

Ezequiel García ezequiel at vanguardiasur.com.ar
Tue Feb 4 21:28:29 UTC 2014


James,

On 29 January 2014 10:03, James Hogan <james.hogan at imgtec.com> wrote:
[..]
>
> Arnd also recommends new kernel ports to use regsets for ptrace
> (PTRACE_{GET,SET}REGSET rather than PTRACE_{PEEK,POKE}USER) so that
> arch_ptrace() is a simple wrapper around ptrace_request. See here for
> example:
> http://marc.info/?l=linux-arch&m=135272829410342&w=2
>

Yes, I saw the REGSET stuff and took some deep look at openrisc and
metag while trying to fix nios2 strace. It is definitely cleaner.

> So the offsets you've added to struct_user_offsets would need removing
> too, and get_regs would need to use get_regset as is done for METAG etc.
> Should simplify the code if anything though.
>

Indeed. Which means we can always fix this later, and this patch _can_
be merged in its current form (with the fixes suggested above).

How does it sounds? If you really want to wait until the arch is
merged upstream, fine by me: I'll stop bothering.
-- 
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar




More information about the Strace-devel mailing list