strace sys_clone bug on x86-32

enh enh at google.com
Thu Apr 10 21:42:16 UTC 2014


On Thu, Apr 10, 2014 at 2:22 PM, Dmitry V. Levin <ldv at altlinux.org> wrote:
> On Wed, Apr 09, 2014 at 06:19:20PM -0700, enh wrote:
>> i don't think
>>
>> commit f94e84780e96221a4b3e8eb39bfa2d227d367f69
> [...]
>> builds for I386, because there's a dangling 'else'.
>
> Indeed, thanks for reporting.  I should have spotted it myself, though.
>
>> that's why my
>> version had the "int print_raw_tls = 1;"
>
> No, it didn't.  At least not the patch you submitted
> (x86-64-user_desc.txt) and I applied.  Now I see print_raw_tls was
> mentioned in the text part of the message, but I surely missed it.

oops. not sure how they got out of sync.

>> alternatively, you could have another #ifdef:
>
> This change is a part of another commit (v4.8-157-g99a0544) that hopefully
> fixes the whole thing.

yes, that's working fine for me for arm, arm64, mips, x86, and x86_64.

(Android's external/strace is now at your ToT and can just be upgraded
with "git merge", which should make things easier in future.)

 --elliott




More information about the Strace-devel mailing list