[PATCH] remove dead "ifndef CLONE_PTRACE" branch, make setbpt easier to read

Dmitry V. Levin ldv at altlinux.org
Thu Jun 23 14:22:19 UTC 2011


On Thu, Jun 23, 2011 at 04:07:17PM +0200, Denys Vlasenko wrote:
> On Thu, 2011-06-23 at 17:26 +0400, Dmitry V. Levin wrote:
> > On Wed, Jun 22, 2011 at 01:48:19PM +0200, Denys Vlasenko wrote:
> > [...]
> > > --- strace.6/util.c	2011-06-22 00:19:30.268714125 +0200
> > > +++ strace.7/util.c	2011-06-22 13:32:30.653923439 +0200
> > > @@ -1494,9 +1494,9 @@ setbpt(struct tcb *tcp)
> > >  		return 0;
> > >  #  endif
> > >  
> > > -	case SYS_clone:
> > > +	case SYS_clone: ;
> > >  #  ifdef SYS_clone2
> > > -	case SYS_clone2:
> > > +	case SYS_clone2: ;
> > >  #  endif
> > >  		/* ia64 calls directly `clone (CLONE_VFORK | CLONE_VM)'
> > >  		   contrary to x86 SYS_vfork above.  Even on x86 we turn the
> > 
> > I wonder what this change was made for?
> 
> Labels cannot be used on declarations. Looks down:
> the next statement is a declaration.

I see, thanks.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20110623/d4435b5d/attachment.bin>


More information about the Strace-devel mailing list