[PATCH] whitespace cleanups

Denys Vlasenko dvlasenk at redhat.com
Tue Jun 7 10:27:16 UTC 2011

On Sat, 2011-06-04 at 12:32 +0400, Dmitry V. Levin wrote:
> On Fri, Jun 03, 2011 at 04:06:51PM +0200, Denys Vlasenko wrote:
> > I know everybody hates whitespace cleanups, so I rolled mine up
> > into one big change. This will be less annoying than
> > gazillion small ones.
> > 
> > For the review, it is split into two patches.
> [...]
> > Dmitry, is it ok with you to apply these?
> The changes are OK (as far as I could verify these monotonous cleanups).
> The main concern with whitespace cleanups is how to enforce a coding style
> to avoid more whitespace cleanups later.

I usually tri to not accumulate it in the first place.

> The method we use now is just
> git diff-index --check, it stops obvious things like trailing whitespace.
> If we are going to do more advanced cleanup, we should try to apply an
> appropriate coding style enforcement as well.
> > If yes, how do you want me to format
> > commit message? Listing every affected function would create a huge list,
> > which doesn't seem to be useful to me...
> Assuming these changes are whitespace only cleanups, I see no use to
> list every affected function.

Pushed to git. Thanks for the review.


More information about the Strace-devel mailing list