[PATCH] whitespace cleanups

Dmitry V. Levin ldv at altlinux.org
Sat Jun 4 08:32:35 UTC 2011

On Fri, Jun 03, 2011 at 04:06:51PM +0200, Denys Vlasenko wrote:
> I know everybody hates whitespace cleanups, so I rolled mine up
> into one big change. This will be less annoying than
> gazillion small ones.
> For the review, it is split into two patches.
> Dmitry, is it ok with you to apply these?

The changes are OK (as far as I could verify these monotonous cleanups).
The main concern with whitespace cleanups is how to enforce a coding style
to avoid more whitespace cleanups later.  The method we use now is just
git diff-index --check, it stops obvious things like trailing whitespace.
If we are going to do more advanced cleanup, we should try to apply an
appropriate coding style enforcement as well.

> If yes, how do you want me to format
> commit message? Listing every affected function would create a huge list,
> which doesn't seem to be useful to me...

Assuming these changes are whitespace only cleanups, I see no use to
list every affected function.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20110604/a36c3f41/attachment.bin>

More information about the Strace-devel mailing list