[PATCH] sh: Add support for tracing sys_cacheflush system call

[Dmitry V. Levin]

On Wed, Dec 01, 2010 at 08:02:48AM +0100, Carmelo AMOROSO wrote:
> On 11/30/2010 5:49 PM, Dmitry V. Levin wrote:
> > On Wed, Nov 24, 2010 at 04:12:48PM +0100, Carmelo AMOROSO wrote:
> > [...]
> >> +#ifdef SH
> >> +static const struct xlat cacheflush_flags[] = {
> >> +	{ CACHEFLUSH_D_INVAL,	"CACHEFLUSH_D_INVAL" },
> >> +	{ CACHEFLUSH_D_WB,		"CACHEFLUSH_D_WB" },
> >> +	{ CACHEFLUSH_D_PURGE,	"CACHEFLUSH_D_PURGE" },
> >> +	{ CACHEFLUSH_I,			"CACHEFLUSH_I" },
> >> +	{ 0,            		NULL },
> >> +};
> > 
> 
> > Are you sure these constants are always available?
> 
> yes, these are defined in asm/cachectl.h, that is present in sh kernel,
> and always defined.
> 
> > Maybe it would be safer to ifdef them like in M68K case?
> >
> 
> I don't think it's worth, but if you prefer this way for consistency
> with other arch, I can easily modify the patch.

Yes, please add these ifdefs.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20101201/ba808a8c/attachment.bin>