[PATCH] sh: Add support for tracing sys_cacheflush system call

[Carmelo AMOROSO]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/30/2010 5:49 PM, Dmitry V. Levin wrote:
> On Wed, Nov 24, 2010 at 04:12:48PM +0100, Carmelo AMOROSO wrote:
> [...]
>> +#ifdef SH
>> +static const struct xlat cacheflush_flags[] = {
>> +	{ CACHEFLUSH_D_INVAL,	"CACHEFLUSH_D_INVAL" },
>> +	{ CACHEFLUSH_D_WB,		"CACHEFLUSH_D_WB" },
>> +	{ CACHEFLUSH_D_PURGE,	"CACHEFLUSH_D_PURGE" },
>> +	{ CACHEFLUSH_I,			"CACHEFLUSH_I" },
>> +	{ 0,            		NULL },
>> +};
> 

Hi

> Are you sure these constants are always available?

yes, these are defined in asm/cachectl.h, that is present in sh kernel,
and always defined.

> Maybe it would be safer to ifdef them like in M68K case?
>

I don't think it's worth, but if you prefer this way for consistency
with other arch, I can easily modify the patch.

Thanks,
Carmelo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkz18xgACgkQoRq/3BrK1s+ZbQCgl/JTzLDX7NI6vj9lL7Pc+wQs
kZQAoL3cwJtfeCmoCbAEq6ChC4LYE8LT
=uLjn
-----END PGP SIGNATURE-----