[PATCH] Blackfin: decode L2_SRAM flag with for l1_sram_alloc()

Mike Frysinger vapier at gentoo.org
Mon Mar 23 18:06:53 UTC 2009


On Monday 23 March 2009 09:14:43 Denys Vlasenko wrote:
> On Wed, 2009-03-18 at 00:24 -0400, Mike Frysinger wrote:
> > Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> > ---
> >  system.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/system.c b/system.c
> > index fc7f869..01dee48 100644
> > --- a/system.c
> > +++ b/system.c
> > @@ -302,6 +302,7 @@ static const struct xlat sram_alloc_flags[] = {
> >  	{ L1_DATA_A_SRAM,	"L1_DATA_A_SRAM" },
> >  	{ L1_DATA_B_SRAM,	"L1_DATA_B_SRAM" },
> >  	{ L1_DATA_SRAM,		"L1_DATA_SRAM" },
> > +	{ L2_SRAM,		"L2_SRAM" },
> >  	{ 0,			NULL },
> >  };
> >
> > @@ -313,7 +314,7 @@ struct tcb *tcp;
> >  		/* size */
> >  		tprintf("%zu, ", tcp->u_arg[0]);
> >  		/* flags */
> > -		printxval(sram_alloc_flags, tcp->u_arg[1], "L1_???_SRAM");
> > +		printxval(sram_alloc_flags, tcp->u_arg[1], "???_SRAM");
> >  	}
> >  	return 1;
> >  }
>
> Applied, thanks!
>
> I also noticed that %zu usage above is wrong, and fixed it,
> then grepped through the tree and found only one other %zu...
> which turned out to be wrong as well. :)

yeah, my fault.  the sram API uses size_t, but obviously the syscall ABI does 
not ... thanks.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20090323/0038863e/attachment.bin>


More information about the Strace-devel mailing list