Bugs with qualify in strace 4.5.15

[Dmitry V. Levin]

On Mon, Aug 20, 2007 at 04:05:25PM -0400, Xiaoning Ding wrote:
[...]
> 2.  function dumpio() in syscall.c.
> 
> Before dumpstr() or dumpiov() is called,  qual_flags[tcp->u_arg[0]] is
> examined against the corresponding qualifier flag. eg.
>  if (qual_flags[tcp->u_arg[0]] & QUAL_WRITE)
>        dumpstr(...)..
> 
> However, tcp->u_arg[0] does not contain any syscall number. Should it
> be replaced with tcp->scno?

tcp->u_arg[0] looks strange for me, too.

BTW, trace_syscall() uses
(qual_flags[tcp->scno] & QUAL_TRACE)
and
(qual_flags[tcp->scno] & QUAL_RAW)
expressions.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20070823/6c453b03/attachment.bin>