[PATCH v5 0/4] Proposal to add eventfd option to --decode-fds

Sahil Siddiq icegambit91 at gmail.com
Thu May 23 14:43:30 UTC 2024


Hi,

I noticed that the most recent commit in strace (f62887c:
Post-release administrivia) adds the "noteworthy changes"
header in NEWS. Since commit #4 of v4 [1] also had this
change, I decided to revert my change and send a new
series.

I have also changed the subject header from "RFC PATCH"
to "PATCH".

Please let me know if more changes have to be made.

Thanks,
Sahil

[1] https://lists.strace.io/pipermail/strace-devel/2024-May/011469.html

Changes v3 -> v5:
- Drop commit #1 from patch v3.
- Change patch series from "RFC PATCH" to "PATCH".
- src/util.c:
  (struct scan_fdinfo): Rename struct.
  (scan_fdinfo_lines):
  - Rename from "scan_fdinfo".
  - (prefix_matches): Use ++ instead of +=1.
  (scan_fdinfo): New wrapper function.
  (get_finfo_for_dev): Revert to use scan_fdinfo wrapper.
  (pidfd_get_pid): Likewise.
  (printsignalfd): Likewise.
  (parse_fdinfo_efd_counter):
  - Improve handling of newline/whitespace.
  - Improve handling of data buffer.
  (printeventfd): Free efd_counter buffer.
- tests/eventfd-yy.c:
  (procfs_check_avail_efd_data):
  - (matches): Use ++ instead of +=1.
  - Modify second "if" condition.
- NEWS: Document this change for next version.

Changes v4 -> v5:
- NEWS: Remove "noteworthy changes" header.

Sahil Siddiq (4):
  Allow scanning of fdinfo fields in one pass
  Add eventfd option to --decode-fds
  Add test for --decode-fds=eventfd
  Document --decode-fds=eventfd implementation

 NEWS                 |   2 +
 doc/strace.1.in      |   5 +-
 src/filter_qualify.c |   1 +
 src/number_set.h     |   1 +
 src/strace.c         |   3 +-
 src/util.c           | 148 +++++++++++++++++++++++++++++---
 tests/.gitignore     |   1 +
 tests/Makefile.am    |   1 +
 tests/eventfd-yy.c   | 196 +++++++++++++++++++++++++++++++++++++++++++
 tests/gen_tests.in   |   1 +
 10 files changed, 347 insertions(+), 12 deletions(-)
 create mode 100644 tests/eventfd-yy.c

-- 
2.45.0



More information about the Strace-devel mailing list