[PATCH v2] Remove redundant clause in condition

Sahil Siddiq icegambit91 at gmail.com
Thu Jan 25 13:09:17 UTC 2024


output_separately is redundant in the third expression as it's
already evaluated in the second expression.

* src/strace.c (init): Remove redundancy in condition.

Complements: v5.6~169 "strace: add a long option aliases for -f and -ff"

Signed-off-by: Sahil Siddiq <icegambit91 at gmail.com>
---
Changes since v1:
 - Add "complements" tag in commit message.

Hi,

I have added the tag. Thank you for the review.

Regards,
Sahil

 src/strace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/strace.c b/src/strace.c
index 780e51e91..19b82dadc 100644
--- a/src/strace.c
+++ b/src/strace.c
@@ -3092,7 +3092,7 @@ init(int argc, char *argv[])
 	 * -p PID1,PID2: yes (there are already more than one pid)
 	 */
 	print_pid_pfx = outfname && !output_separately &&
-		((followfork && !output_separately) || nprocs > 1);
+		(followfork || nprocs > 1);
 }
 
 static struct tcb *
-- 
2.43.0



More information about the Strace-devel mailing list