[PATCH strace] Implement decoding of RXRPC_* control messages

David Howells dhowells at redhat.com
Wed May 31 14:40:16 UTC 2023


Dmitry V. Levin <ldv at strace.io> wrote:

> I suppose a switch statement would be more concise in this case.

It would be 13 lines rather than 8, but it looks neater.

> Looks like this table would benefit from #value_indexed.

Done.

> By the way, would it make sense to list RXRPC_ACCEPT here as well, even
> though it was removed from the kernel by commit v4.9-rc1~127^2~247^2?

I can add it.

> And the last but not least, do you have any ideas how this new decoder
> could be tested?

Something like this:

	https://people.redhat.com/dhowells/rxrpc/rxrpc.c
	https://people.redhat.com/dhowells/rxrpc/listen.c

but it needs cleaning up.  It shouldn't need any external infrastructure, but
it does require a client and a server and a UDP port to listen on.

Do you want something that lives in the tests/ directory?

David



More information about the Strace-devel mailing list