[PATCH v4] v4l2: Add support for interpreting remaining fields in VIDIOC_ENUMINPUT struct v4l2_input

Dmitry V. Levin ldv at strace.io
Wed May 17 08:19:15 UTC 2023


On Wed, May 17, 2023 at 01:41:11AM +0200, Marek Vasut wrote:
> On 5/17/23 00:48, Dmitry V. Levin wrote:
> > On Sun, May 14, 2023 at 08:53:27PM +0200, Marek Vasut wrote:
> > [...]
> >> @@ -787,6 +790,19 @@ print_v4l2_input(struct tcb *const tcp, const kernel_ulong_t arg)
> >>   		tprint_struct_next();
> >>   		PRINT_FIELD_XVAL(i, type, v4l2_input_types,
> >>   				 "V4L2_INPUT_TYPE_???");
> >> +		tprint_struct_next();
> >> +		PRINT_FIELD_X(i, audioset);
> >> +		tprint_struct_next();
> >> +		PRINT_FIELD_U(i, tuner);
> > 
> > PRINT_FIELD_XVAL(i, tuner, v4l2_tuner_types, "V4L2_TUNER_???");
> 
> I do not understand this feedback, sorry. Can you please provide any 
> further details ?
> 
> Note that the tuner field in struct v4l2_input is tuner _index_, not 
> tuner type, in case this is what the suggestion is about .

No problem, if struct v4l2_input.tuner is indeed an index and not an
enum v4l2_tuner_type, then I've just been confused by the corresponding
comment in include/uapi/linux/videodev2.h


-- 
ldv


More information about the Strace-devel mailing list