[PATCH v4 3/3] Add tests for the -l/--syscall-limit option

[Sahil Siddiq]

Hi,

On Saturday, 18 March 2023 17:35:51 IST Dmitry V. Levin wrote:
> On Sat, Mar 04, 2023 at 07:02:17PM +0530, Sahil Siddiq wrote:
> [...]
> 
> > --- a/tests/gen_tests.in
> > +++ b/tests/gen_tests.in
> > @@ -1006,6 +1006,8 @@ strace--strings-in-hex-all                --trace=chdir --strings-in-hex=all --columns=18> 
> >  strace--strings-in-hex-non-ascii        --trace=chdir --strings-in-hex=non-ascii --columns=12
> >  strace--strings-in-hex-non-ascii-chars  --trace=chdir --strings-in-hex=non-ascii-chars --columns=12
> >  strace--strings-in-hex-none             --trace=chdir --strings-in-hex=none --columns=12
> > +strace--syscall-limit-path     +strace--syscall-limit.test --trace=all --trace-path=. --trace-path=invalid.dir
> > +strace--syscall-limit-status   +strace--syscall-limit.test --trace=chdir,openat --status=failed
> The "strace--syscall-limit" test seems to be lost.

Sorry, I didn't understand what you mean. I removed "strace--syscall-limit" from
gen_tests.in because I have manually written the test in "strace--syscall-limit.test".
The other two tests, however, are still generated.

I have added "strace--syscall-limit.test" to MISC_TESTS in the Makefile so that
it runs with "make check".

> Please avoid testing against openat because it's used by dynamic linker
> and therefore the number of openat invocations is not predictable.

Sure, I'll change this.

Thanks,
Sahil