[PATCH v3 1/3] Stop condition based on number of syscalls

[Sahil Siddiq]

Hi,

On Thursday, 2 March 2023 16:11:53 IST Dmitry V. Levin wrote:
> 
> > @@ -1108,7 +1113,7 @@ droptcb(struct tcb *tcp)
> >                                              fprintf(tcp->outf, " <detached ...>\n");
> >                        fclose(tcp->outf);
> >            } else {
> > -                      if (printing_tcp == tcp && tcp->curcol != 0 && publish)
> > +                     if (syscall_limit == 0 || (printing_tcp == tcp && tcp->curcol != 0 && publish))
> >                                              fprintf(tcp->outf, " <detached ...>\n");
> >                        flush_tcp_output(tcp);
> 
> As " <detached ...>\n" is printed only in case when a syscall hasn't
> been completely decoded, I don't see why do you want to print this
> unconditionally in case of syscall_limit == 0.
> I suggest not to change this logic at all: detach() already issues
> "Process %u detached" message, that should be enough.

Sure, I'll fix this. Thanks for the feedback.

Regards,
Sahil