[PATCH v2 2/2] [GSoC] Make relevant changes in NEWS and man page

[icegambit91 at gmail.com]

Hi,

On Thursday, 16 February 2023 16:00:27 IST Dmitry V. Levin wrote:
> On Wed, Feb 15, 2023 at 11:37:06PM +0530, Sahil Siddiq wrote:
> [...]
> 
> > @@ -1332,6 +1334,12 @@ field is not supplied explicitly, it is added as
> > the last column.> 
> >  .B \-\-summary\-wall\-clock
> >  Summarise the time difference between the beginning and end of
> >  each system call.  The default is to summarise the system time.
> > 
> > +.SS Stop condition
> > +.TP 12
> > +.BI "\-l " limit
> > +.TQ
> > +.BR "\-\-syscall\-limit" = \fIlimit\fR
> > +Detach/stop strace after \fIlimit\fR number of syscalls are captured.
> 
> I'm not sure what exactly do you mean by "captured syscalls".

By "captured syscalls", I was referring to syscalls that are handled and are not
filtered out (so, syscalls that are decoded and printed).

> there are syscalls printed by strace, this excludes those syscall that
> were handled but filtered out at different stages and therefore not printed.
> 
> The filtering could be performed by --trace=, --trace-path=, and --status=;
> my guess is that you intended to take all this filtering into account.

Yes, this is my intention. So, syscalls that are filtered out will not be considered
in the maximum syscall count for detaching strace.

> Anyway, this new feature needs a test.  Maybe even 3 tests:
> one test for each of these 3 filtering methods.

Sure, I'll send in a new patch with the tests. Thank you for reviewing.

Regards,
Sahil