[PATCH v6 3/3] tests: check -l/--syscall-limit options

[Sahil Siddiq]

Hi,

On Sunday, 23 April 2023 00:40:10 IST Dmitry V. Levin wrote:
> On Sun, Apr 23, 2023 at 12:06:58AM +0530, Sahil Siddiq wrote:
> > Hi,
> > 
> > On Friday, 21 April 2023 03:03:08 IST Dmitry V. Levin wrote:
> > > [...]
> > > 
> > > I've reworked the test a bit, please have a look.
> > 
> > Thank you for the feedback. I think these changes make the tests a lot
> > better. They are more concise.
> > 
> > > --- a/tests/gen_tests.in
> > > +++ b/tests/gen_tests.in
> > > @@ -1006,6 +1006,8 @@ strace--strings-in-hex-all --trace=chdir
> > > --strings-in-hex=all --columns=18 strace--strings-in-hex-non-ascii
> > > --trace=chdir --strings-in-hex=non-ascii --columns=12
> > > strace--strings-in-hex-non-ascii-chars --trace=chdir
> > > --strings-in-hex=non-ascii-chars --columns=12
> > > strace--strings-in-hex-none --trace=chdir --strings-in-hex=none
> > > --columns=12 +strace--syscall-limit-path +strace--syscall-limit.test
> > > --trace=all --trace-path=invalid.dir +strace--syscall-limit-status
> > > +strace--syscall-limit.test --status=failed> 
> > Could "--trace=all" be removed from the rule for generating
> > strace--syscall-limit-path since --trace='chdir,rmdir' is set in
> > strace--syscall-limit.test?
> 
> This --trace=all goes after --trace='chdir,rmdir' and therefore overrides
> it,

Ok, this makes sense.

> but since there are no syscalls accessing invalid.dir besides these
> two, I agree that --trace=all seems to be redundant here.

Alright, I'll send a new patch series with all the changes together.

Regards,
Sahil