[PATCH] xlat: update ST_NOSYMFOLLOW constant

Dmitry V. Levin ldv at altlinux.org
Fri Mar 26 00:52:23 UTC 2021


Since the change itself is trivial, I'll be extra picky about details
so you could get a taste of patch review process.

On Wed, Mar 24, 2021 at 09:26:33PM -0700, Deborah Brouwer wrote:
> Linux 5.10 introduced new constant ST_NOSYMFOLLOW.
> Signed-off-by: Deborah Brouwer <3563deb6753 at gmail.com>

As we try to be more specific nowadays, we usually mention the Linux
kernel commit introduced the new constant, see e.g. strace commit

We also try to list user visible changes in the NEWS file, see e.g.
the same commit.

Sometimes we also update tests to check printing of new constants, but
that is not mandatory.

The first line of the commit message says "xlat: update ST_NOSYMFOLLOW
constant" which is a bit misleading because the change doesn't update

> ---
>  src/xlat/statfs_flags.in | 1 +
>  1 file changed, 1 insertion(+)
> diff --git a/src/xlat/statfs_flags.in b/src/xlat/statfs_flags.in
> index f791a60e..90a06138 100644
> --- a/src/xlat/statfs_flags.in
> +++ b/src/xlat/statfs_flags.in
> @@ -8,3 +8,4 @@ ST_MANDLOCK	0x0040
>  ST_NOATIME	0x0400
>  ST_RELATIME	0x1000

This part is fine.


More information about the Strace-devel mailing list