[PATCH 3/3] hdio: improve HDIO support

Dmitry V. Levin ldv at altlinux.org
Tue Aug 31 09:16:55 UTC 2021


On Sat, Aug 21, 2021 at 09:52:00AM -0400, Srikavin Ramkumar wrote:
[...]
> diff --git a/src/xlat/hdio_busstates.in b/src/xlat/hdio_busstates.in
> new file mode 100644
> index 000000000..7daea8584
> --- /dev/null
> +++ b/src/xlat/hdio_busstates.in
> @@ -0,0 +1,5 @@
> +#enum
> +#include <linux/hdreg.h>
> +BUSSTATE_OFF        0
> +BUSSTATE_ON         1
> +BUSSTATE_TRISTATE   2

Given that <linux/hdreg.h> is quite stable, I suppose we can simplify this
by using #unconditional instead of fallback definitions, e.g.

#unconditional
#value_indexed
BUSSTATE_OFF
BUSSTATE_ON
BUSSTATE_TRISTATE


-- 
ldv


More information about the Strace-devel mailing list