[PATCH] configure.ac: remove unused checks

Dmitry V. Levin ldv at altlinux.org
Wed May 13 00:40:38 UTC 2020


Hi,

On Tue, May 12, 2020 at 12:21:14AM +0100, Pierre Marsais wrote:
> * configure.ac (AC_CHECK_FUNCS): Remove utimensat, removed in 589cff6.
> Remove strsignal, removed in 2c4fb90.
> (AC_CHECK_HEADERS): Remove sys/conf.h, removed in 811bda6. Remove
> stropts.h, removed in a56a81c.
> 
> Signed-off-by: Pierre Marsais <pierre.marsais at lse.epita.fr>
> ---
> Hi Strace developers,
> 
> Looking at configure.ac I found some checks that seems unused. This
> patch removes them. If this kind of patch is welcome, it seems that
> inttypes.h is also checked by AC_CHECK_HEADERS, but its
> HAVE_INTTYPES_H macro is not used.
> 
> Best regards,

Thanks, such cleanup is always welcome.
I wonder what kind of tool was used to find these obsolete checks.

The commit message is somewhat confusing, I suggest e.g. replacing
"Remove NAME, removed in COMMIT" with
"Remove NAME, the last user was removed by commit COMMIT".


-- 
ldv


More information about the Strace-devel mailing list